Skip to content

Conversation

@naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Apr 22, 2024

  • Natspec updated
  • prettier and lint
  • removed strategist from strategy as its already in the Vault
  • Fixed spelling in some events
  • Generated contract docs for Native Staking Strategy

Fixed spelling of ValidatorAccountant events
Implemented depositSSV
@github-actions
Copy link

github-actions bot commented Apr 22, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against e94858b

@naddison36 naddison36 marked this pull request as ready for review April 22, 2024 12:18
modifier onlyStrategist() {
require(msg.sender == strategist, "Caller is not the Strategist");
require(
msg.sender == IVault(VAULT_ADDRESS).strategistAddr(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better yes thanks!

IWETH9(WETH_TOKEN_ADDRESS).deposit{ value: wethToVault }();
IWETH9(WETH_TOKEN_ADDRESS).transfer(VAULT_ADDRESS, wethToVault);

emit AccuntingFullyWithdrawnValidator(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha that is a bad typo :D

Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great thanks!

@sparrowDom sparrowDom merged commit 121c7f7 into sparrowDom/nativeStaking Apr 22, 2024
@sparrowDom sparrowDom deleted the nicka/nativeStaking branch April 22, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants