Remove unproxy for built-in APIs #116
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We needed to apply a
unproxy
wrapper to every built-in API as passingProxy
objects into the backend causes segmentation fault.However, this
unproxy
step is not very efficient as it requires iterating and type-checking every argument every time a low-level (presumably also a very frequently-called) API is being invoked, leading to performance overheads.Also, generally we want to reduce number of APIs instrumented to (1) lower the overhead & (2) reduce the intrusiveness of our instrumentation.
Why:
The
segmentation fault
issue has been resolved by #115 which uses__torch_function__
to automatically unproxy objects when a Proxy object is being dispatched.TODOs:
global_wrapper
except when adding observers.core_wrapper
completely.