Skip to content

fix(governance): add underflow protection in vote override subtraction #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+7 −1
Closed

fix(governance): add underflow protection in vote override subtraction #6122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion contracts/governance/extensions/GovernorCountingOverridable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ abstract contract GovernorCountingOverridable is GovernorVotes {

error GovernorAlreadyOverriddenVote(address account);

error GovernorInsufficientDelegateVotes(uint256 available, uint256 required);

mapping(uint256 proposalId => ProposalVote) private _proposalVotes;

/// @inheritdoc IGovernor
Expand Down Expand Up @@ -153,7 +155,11 @@ abstract contract GovernorCountingOverridable is GovernorVotes {
proposalVote.voteReceipt[delegate].overriddenWeight += SafeCast.toUint208(overriddenWeight);
} else {
uint8 delegateSupport = delegateCasted - 1;
proposalVote.votes[delegateSupport] -= overriddenWeight;
uint256 currentVotes = proposalVote.votes[delegateSupport];
if (currentVotes < overriddenWeight) {
revert GovernorInsufficientDelegateVotes(currentVotes, overriddenWeight);
}
proposalVote.votes[delegateSupport] = currentVotes - overriddenWeight;
emit VoteReduced(delegate, proposalId, delegateSupport, overriddenWeight);
}

Expand Down
Loading