Skip to content

Conversation

@GarmashAlex
Copy link
Contributor

there is no guarantees -> there are no guarantees
corresponding is an NFT -> corresponding token is an NFT
any token exist -> any token exists

@GarmashAlex GarmashAlex requested a review from a team as a code owner November 14, 2025 12:47
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

⚠️ No Changeset found

Latest commit: 6589502

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

Walkthrough

The pull request updates documentation in the ERC1155Supply.sol contract. Three changes were made to comments and docstrings: clarifying that "totalSupply of 1 might mean the corresponding token is an NFT", correcting grammar in a statement about token minting guarantees from "there is no guarantees" to "there are no guarantees", and fixing a duplicate word typo in the exists function documentation from "whether whether any token exist" to "whether any token exists". No changes were made to function signatures or implementation logic.

Suggested labels

typo

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: typos in ERC1155 extension' accurately summarizes the main change: correcting three typos in documentation comments within the ERC1155Supply.sol file.
Description check ✅ Passed The description is directly related to the changeset, clearly listing the three specific typo corrections made in the ERC1155 extension documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6308fdc and 6589502.

📒 Files selected for processing (1)
  • contracts/token/ERC1155/extensions/ERC1155Supply.sol (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: coverage
  • GitHub Check: slither
  • GitHub Check: halmos
  • GitHub Check: tests
  • GitHub Check: tests-upgradeable
  • GitHub Check: tests-foundry
  • GitHub Check: Redirect rules - solidity-contracts
  • GitHub Check: Header rules - solidity-contracts
  • GitHub Check: Pages changed - solidity-contracts
🔇 Additional comments (2)
contracts/token/ERC1155/extensions/ERC1155Supply.sol (2)

13-15: Documentation improvements are correct.

Both corrections on these lines properly fix grammar issues: "corresponding token is" clarifies the referent, and "there are no guarantees" corrects subject-verb agreement.


43-43: Documentation fix is correct.

The docstring properly removes the duplicate "whether" and corrects "exist" to "exists" for singular subject agreement.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ernestognw ernestognw changed the base branch from master to typo-fixes November 19, 2025 19:54
@ernestognw ernestognw merged commit ea71000 into OpenZeppelin:typo-fixes Nov 19, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants