Fix/#1355 test helper to check balance difference #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a688977.
nventuro
reviewed
Oct 1, 2018
Contributor
nventuro
left a comment
nventuro
left a comment
There was a problem hiding this comment.
Great @Aniket-Engg, thanks a lot! Looks like multiple files were also committed here, undoing previous PRs of ours: make sure you create your branch from an updated master branch to prevent this sort of issues. Could you remove those from this PR?
nventuro
added
feature
nventuro
approved these changes
Oct 1, 2018
Contributor
nventuro
left a comment
nventuro
left a comment
There was a problem hiding this comment.
Great @Aniket-Engg, thanks a lot! This will be very helpful for the planned helpers package 😁
Contributor
Author
|
Your most welcome @nventuro |
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* signing prefix added * Minor improvement * Tests changed * Successfully tested * Minor improvements * Minor improvements * Revert "Dangling commas are now required. (#1359)" This reverts commit a688977. * fixex #1355 * linting * suggested changes * Update BreakInvariantBounty.test.js (cherry picked from commit 6ae041b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1355
🚀 Description
Test helper to check balance difference, tested in
BreakInvariantBounty.test.jsnpm run lint:fix).