Improved bounty tests. #1350
Merged
Improved bounty tests. #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-maiz
reviewed
Sep 26, 2018
| contract SecureInvariantTargetMock is Target { | ||
| function checkInvariant() public returns(bool) { | ||
| contract TargetMock is Target { | ||
| bool private pwned; |
There was a problem hiding this comment.
nit, change to exploited or something less 1337.
come-maiz
reviewed
Sep 26, 2018
test/BreakInvariantBounty.test.js
Outdated
| }); | ||
| }); | ||
| it('can set reward', async function () { | ||
| await sendReward(owner, this.bounty.address, reward); |
There was a problem hiding this comment.
I don't like this sendReward name. What would you think of dropping the function and just calling web3.eth.sendTransaction?
come-maiz
reviewed
Sep 26, 2018
come-maiz
reviewed
Sep 26, 2018
come-maiz
reviewed
Sep 26, 2018
frangio
reviewed
Sep 26, 2018
This was referenced Sep 26, 2018
frangio
pushed a commit
that referenced
this pull request
Sep 26, 2018
* Improved bounty tests. * Fixed linter errors. * Addressed review comments. (cherry picked from commit ae109f6)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old tests were downright bizarre: the new suite better shows how bounty can be claimed after a vulnerability is exploited. Also, coverage should now be 100%.