Skip to content

Conversation

@glesaint
Copy link
Contributor

🚀 Description

MathMock contract imports a file that exists only if the "contracts" folder is named contracts.
This PR fixes it so it uses a relative path.

ISSUE

  • If file is in: repo/contracts/openzeppelin/mocks/MathMock.sol
  • It imports (fails) repo/contracts/contracts/math/Math.sol

FIX

  • If file is in: repo/contracts/openzeppelin/mocks/MathMock.sol
  • It imports (success) repo/contracts/openzeppelin/math/Math.sol
  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • [N/A?] ✅ I've added tests where applicable to test my new functionality.
  • [N/A?] 📖 I've made sure that my contracts are well-documented.
  • [N/A?] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @glesaint, thanks! I'll check if there are more instances of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants