Fix decrease allowance and add non-zero address precondition to approve #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
added
kind:improvement
contracts
nventuro
approved these changes
Sep 7, 2018
This was referenced Apr 15, 2019
wjmelements
reviewed
Dec 3, 2019
Contributor
wjmelements
left a comment
wjmelements
left a comment
There was a problem hiding this comment.
So much havoc from one change, wow
Contributor
This is in reference to f306cc8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decreaseAllowancenow requires the current allowance to not be larger than the amount to decrease. If the intent is to decrease the allowance to 0,approve(0)should be used instead.Fixes #437.
Additionally adds a check that an address is non-zero, which is the convention across OpenZeppelin.
Tests need fixed.