Fix balance and allowance checks in _burn and _burnFrom #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Aug 17, 2018
| }; | ||
|
|
||
| describeBurn('for entire balance', initialSupply); | ||
| describeBurn('for less amount than balance', new BigNumber(50)); |
Contributor
Author
There was a problem hiding this comment.
Yes, I can do that, but can you explain the reasoning?
Contributor
There was a problem hiding this comment.
To prevent having to keep those values in sync: it doesn't matter what the actual amounts are, only that this one is lower, and the only way to verify that is to go check against the other one.
Additionally, the .sub thing makes it crystal clear what it should be less than.
nventuro
approved these changes
Aug 17, 2018
This was referenced Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217.