Skip to content

Conversation

@barakman
Copy link
Contributor

@barakman barakman commented Aug 7, 2018

Fixes #

πŸš€ Description

  • [x ] πŸ“˜ I've reviewed the OpenZeppelin Contributor Guidelines
  • [x ] βœ… I've added tests where applicable to test my new functionality.
  • [x ] πŸ“– I've made sure that my contracts are well-documented.
  • [x ] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @barakman!

The reason the build is failing is because you need to specify the from: owner in both claimable.transferOwnership calls, since only the owner is allowed to do those.

@nventuro nventuro self-assigned this Aug 7, 2018
@nventuro nventuro added this to the v2.0 milestone Aug 7, 2018
@barakman
Copy link
Contributor Author

barakman commented Aug 8, 2018

@nventuro:
Yes, you're absolutely right.
Function transferOwnership (and any other state-changing function for that matter), should be called with { from: owner }, in order for this "non-default" owner to work.
I committed this in a haste, so missed it.
You are still going to apply this fix, right?

@nventuro
Copy link
Contributor

nventuro commented Aug 8, 2018

I fixed it on your branch so we can move along with this, thanks!

@nventuro nventuro merged commit eca5bf9 into OpenZeppelin:master Aug 8, 2018
@barakman barakman deleted the patch-7 branch August 8, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug contracts Smart contract code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants