Added explicit data locations for function parameters to comply with Solidity v050 changes.

[chase1745]

🚀 Description

Solidity v050 will no longer allow default data locations for function parameters (and return parameters) (argotorg/solidity#4014), so all such instances have been made explicit memory locations.

• 📘 I've reviewed the OpenZeppelin Contributor Guidelines
• ✅ I've added tests where applicable to test my new functionality.
• 📖 I've made sure that my contracts are well-documented.
• 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

[nventuro]

Awesome, thanks @chase1745! I want to leave this one open until argotorg/solidity#4014 is merged, so that we can test against the solidity nightly build.

[chase1745]

argotorg/solidity#4518 is now the PR that contains the breaking changes, just for reference.

[nventuro]

Now tracking argotorg/solidity#4738.

[nventuro]

Woot @chase1745 looks like argotorg/solidity#4738 was finally merged! We should be able to test against nightly builds now - could you fix the merge conflicts so that we can move along with this once the build passes? Thanks!

[chase1745]

@nventuro Should be good to go👍

[chase1745]

It's failing the CI build because calldata was not a keyword in previous versions, but it now is required, so when it runs against the latest build with v050 it should pass.

[nventuro]

That's inconvenient - it doesn't exist in previous versions and is now required?

Given that, is there a way we can have OZ compile in both 0.4.24 and 0.5.0 (without having to use the experimental pragma)?

[leonardoalt]

@nventuro @chase1745
In that case (where calldata is now mandatory for v0.5.0) I don't think you can compile the same code with the different versions. There are probably other similar cases, as 0.5.0 brings many changes.

[nventuro]

I feared this may be the case. I don't want to drop our testing using the nightly build though - I'll try to come up with a way to handle this (e.g. a script that patches our source code) during the next couple days. Until then, this should be on hold, so we can keep things tidy and on the same PR.

[nventuro]

I've updated the PR to target the solc-nightly branch, though with the recent 2.0 renaming it may be easier to simply do these changes again from scratch.

[axic]

Most of this should be backwards compatible and could be merged on master. What is not backwards compatible is the calldata keyword as that was added newly.

[nventuro]

Fixed via e5b94c1