Skip to content

Conversation

@rwaffen
Copy link
Member

@rwaffen rwaffen commented May 23, 2025

No description provided.

@rwaffen rwaffen requested review from bastelfreak and nmburgan May 23, 2025 16:11
@rwaffen rwaffen added enhancement New feature or request tech-debt labels May 23, 2025
File.write("#{modpath}/#{mod_name}/tasks/atask.json", "NOT JSON")

expect(Puppet).to receive(:send_log).with(:err, /unexpected token at 'NOT JSON'/)
expect(Puppet).to receive(:send_log).with(:err, /unexpected token|unexpected character|parse error/i)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this when I took a pass at the tests earlier (never finished). I wonder why it's different. 🤔

@rwaffen
Copy link
Member Author

rwaffen commented May 23, 2025

down from

25308 examples, 81 failures, 22 pending

to

25308 examples, 14 failures, 22 pending

@nmburgan nmburgan merged commit eb85d4a into OpenVoxProject:main May 23, 2025
1 of 8 checks passed
@rwaffen rwaffen deleted the rscpec branch May 23, 2025 16:28
@smortex smortex added skip-changelog Excluded from CHANGELOG and removed enhancement New feature or request labels May 28, 2025
nmburgan pushed a commit that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Excluded from CHANGELOG tech-debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants