-
Notifications
You must be signed in to change notification settings - Fork 0
OTP FLOW Tweaks #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
OTP FLOW Tweaks #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71faa0c to
efb8313
Compare
Signed-off-by: romanetar <[email protected]>
0b464e5 to
dd00827
Compare
Signed-off-by: romanetar <[email protected]>
6654bf1 to
efd9d51
Compare
smarcet
reviewed
Feb 13, 2024
smarcet
reviewed
Feb 14, 2024
smarcet
requested changes
Feb 14, 2024
Collaborator
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romanetar please review comments
smarcet
reviewed
Feb 14, 2024
resources/views/emails/oauth2_passwordless_otp_reg_reminder_fn.blade.php
Outdated
Show resolved
Hide resolved
efd9d51 to
e688dbb
Compare
e688dbb to
1de1abb
Compare
Signed-off-by: romanetar <[email protected]>
1de1abb to
e04e8f1
Compare
Change-Id: Ieedb7e7be88d84030c1995e6e482ea355f9e6066
Change-Id: I547db8f9b308776e201aee1c9907c7ad21ae7c11
smarcet
reviewed
Mar 13, 2024
Collaborator
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://tipit.avaza.com/project/view#!tab=task-pane&groupby=MyTaskProject&view=vertical&task=3478546&stafilter=NotComplete&fileview=grid
https://tipit.avaza.com/project/view/185581#!tab=task-pane&groupby=ProjectSection&view=vertical&task=3480479&stafilter=NotComplete&fileview=grid
https://tipit.avaza.com/project/view/185581#!tab=task-pane&groupby=ProjectSection&view=vertical&task=3482868&stafilter=NotComplete&fileview=grid
Signed-off-by: romanetar [[email protected]]