Skip to content

Conversation

@martin-frbg
Copy link
Collaborator

the cmake build already generated the interface functions, but neither the gmake build nor the cblas.h had them. Fixes #3063

@martin-frbg martin-frbg changed the title Add cblas_csrot and cblas_zdrot Add cblas_crotg, cblas_zrotg, cblas_csrot and cblas_zdrot Jan 12, 2021
@martin-frbg martin-frbg added this to the 0.3.14 milestone Jan 12, 2021
@martin-frbg martin-frbg merged commit 3628b22 into OpenMathLib:develop Jan 14, 2021
@mu578
Copy link

mu578 commented Jan 14, 2021

@martin-frbg ok thanks; do you know (historically) for the ?rotg? family? why it has been decided not to transpose back the packed-format-matrix i.e param ; that's the only weirdo which doesn't respect row-major storage. By any logical means cblas_?rotmg should have been declared as the following:

cblas_?rotmg(const enum CBLAS_ORDER order, type * d1, type * d2, type * b1, const type b2, type * param);

then param result transposed as it actually returns [ flag, h11, h21, h12, h22 ]; in row-major storage anyone would expect [ flag, h11, h12, h21, h22 ].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cblas_csrot cblas_zdrot frontends missing; request implementation.

2 participants