Build error on MacOSX 10.15.7

[healther]

I hope this is the correct place to open this build issue, if not: Is there a better place to go?

Last week I (maybe foolishly) tried to upgrade my software stack managed with spack, I am up to date both in Xcode (12.0.0) and MacOSX and it feels that living this close to the edge becomes unhealthy. At least OpenBLAS in version 0.3.10 fails with the following error message:

    'make' '-j4' 'CC=/Users/healther/Documents/git.nosync/spack/lib/spack/env/clang/clang' 'FC=/Users/healther/Documents/git.nosync/spack/lib/spack/env/clang/gfortran' 'MAKE_NB_JOBS=0' 'ARCH=x86_64' 'DYNAMIC_ARCH=1' 'USE_OPENMP=0' 'USE_THREAD=0' 'libs' 'netlib' 'shared'

9 errors found in build log:
     19695    /Users/healther/Documents/git.nosync/spack/lib/spack/env/clang/clang -O2 -DMAX_STACK_ALLOC=2048 -DEXPRECISION -Wall -m64 -DF_INTERFACE_
              GFORT -fPIC -DDYNAMIC_ARCH -DNO_WARMUP -DMAX_CPU_NUMBER=4 -DMAX_PARALLEL_NUMBER=1 -DVERSION="0.3.10" -UASMNAME -UASMFNAME -UNAME -UCNAM
              E -UCHAR_NAME -UCHAR_CNAME -DASMNAME=_ -DASMFNAME=__ -DNAME=_ -DCNAME= -DCHAR_NAME="_" -DCHAR_CNAME="" -DNO_AFFINITY -I. -DHAVE_LAPACK_
              CONFIG_H -I../include -c -o lapacke_zupmtr_work.o lapacke_zupmtr_work.c
     19696    /Users/healther/Documents/git.nosync/spack/lib/spack/env/clang/clang -O2 -DMAX_STACK_ALLOC=2048 -DEXPRECISION -Wall -m64 -DF_INTERFACE_
              GFORT -fPIC -DDYNAMIC_ARCH -DNO_WARMUP -DMAX_CPU_NUMBER=4 -DMAX_PARALLEL_NUMBER=1 -DVERSION="0.3.10" -UASMNAME -UASMFNAME -UNAME -UCNAM
              E -UCHAR_NAME -UCHAR_CNAME -DASMNAME=_ -DASMFNAME=__ -DNAME=_ -DCNAME= -DCHAR_NAME="_" -DCHAR_CNAME="" -DNO_AFFINITY -I. -DHAVE_LAPACK_
              CONFIG_H -I../include -c -o lapacke_cggsvp.o lapacke_cggsvp.c
     19697    /Users/healther/Documents/git.nosync/spack/lib/spack/env/clang/clang -O2 -DMAX_STACK_ALLOC=2048 -DEXPRECISION -Wall -m64 -DF_INTERFACE_
              GFORT -fPIC -DDYNAMIC_ARCH -DNO_WARMUP -DMAX_CPU_NUMBER=4 -DMAX_PARALLEL_NUMBER=1 -DVERSION="0.3.10" -UASMNAME -UASMFNAME -UNAME -UCNAM
              E -UCHAR_NAME -UCHAR_CNAME -DASMNAME=_ -DASMFNAME=__ -DNAME=_ -DCNAME= -DCHAR_NAME="_" -DCHAR_CNAME="" -DNO_AFFINITY -I. -DHAVE_LAPACK_
              CONFIG_H -I../include -c -o lapacke_cggsvp_work.o lapacke_cggsvp_work.c
     19698    /Users/healther/Documents/git.nosync/spack/lib/spack/env/clang/clang -O2 -DMAX_STACK_ALLOC=2048 -DEXPRECISION -Wall -m64 -DF_INTERFACE_
              GFORT -fPIC -DDYNAMIC_ARCH -DNO_WARMUP -DMAX_CPU_NUMBER=4 -DMAX_PARALLEL_NUMBER=1 -DVERSION="0.3.10" -UASMNAME -UASMFNAME -UNAME -UCNAM
              E -UCHAR_NAME -UCHAR_CNAME -DASMNAME=_ -DASMFNAME=__ -DNAME=_ -DCNAME= -DCHAR_NAME="_" -DCHAR_CNAME="" -DNO_AFFINITY -I. -DHAVE_LAPACK_
              CONFIG_H -I../include -c -o lapacke_dggsvp.o lapacke_dggsvp.c
     19699    /Users/healther/Documents/git.nosync/spack/lib/spack/env/clang/clang -O2 -DMAX_STACK_ALLOC=2048 -DEXPRECISION -Wall -m64 -DF_INTERFACE_
              GFORT -fPIC -DDYNAMIC_ARCH -DNO_WARMUP -DMAX_CPU_NUMBER=4 -DMAX_PARALLEL_NUMBER=1 -DVERSION="0.3.10" -UASMNAME -UASMFNAME -UNAME -UCNAM
              E -UCHAR_NAME -UCHAR_CNAME -DASMNAME=_ -DASMFNAME=__ -DNAME=_ -DCNAME= -DCHAR_NAME="_" -DCHAR_CNAME="" -DNO_AFFINITY -I. -DHAVE_LAPACK_
              CONFIG_H -I../include -c -o lapacke_dggsvp_work.o lapacke_dggsvp_work.c
     19700    /Users/healther/Documents/git.nosync/spack/lib/spack/env/clang/clang -O2 -DMAX_STACK_ALLOC=2048 -DEXPRECISION -Wall -m64 -DF_INTERFACE_
              GFORT -fPIC -DDYNAMIC_ARCH -DNO_WARMUP -DMAX_CPU_NUMBER=4 -DMAX_PARALLEL_NUMBER=1 -DVERSION="0.3.10" -UASMNAME -UASMFNAME -UNAME -UCNAM
              E -UCHAR_NAME -UCHAR_CNAME -DASMNAME=_ -DASMFNAME=__ -DNAME=_ -DCNAME= -DCHAR_NAME="_" -DCHAR_CNAME="" -DNO_AFFINITY -I. -DHAVE_LAPACK_
              CONFIG_H -I../include -c -o lapacke_sggsvp.o lapacke_sggsvp.c
  >> 19701    lapacke_cggsvp_work.c:52:9: error: implicit declaration of function 'cggsvp_' is invalid in C99 [-Werror,-Wimplicit-function-declaratio
              n]
     19702            LAPACK_cggsvp( &jobu, &jobv, &jobq, &m, &p, &n, a, &lda, b, &ldb, &tola,
     19703            ^
     19704    ../include/lapack.h:3771:23: note: expanded from macro 'LAPACK_cggsvp'
     19705    #define LAPACK_cggsvp LAPACK_GLOBAL(cggsvp,CGGSVP)
     19706                          ^
     19707    ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'

     ...

     19729    ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'
     19730    #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
     19731                                          ^
     19732    <scratch space>:94:1: note: expanded from here
     19733    cggsvp3_
     19734    ^
  >> 19735    lapacke_cggsvp_work.c:139:9: error: implicit declaration of function 'cggsvp_' is invalid in C99 [-Werror,-Wimplicit-function-declarati
              on]
     19736            LAPACK_cggsvp( &jobu, &jobv, &jobq, &m, &p, &n, a_t, &lda_t, b_t,
     19737            ^
     19738    ../include/lapack.h:3771:23: note: expanded from macro 'LAPACK_cggsvp'
     19739    #define LAPACK_cggsvp LAPACK_GLOBAL(cggsvp,CGGSVP)
     19740                          ^
     19741    ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'
     19742    #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
     19743                                          ^
     19744    <scratch space>:229:1: note: expanded from here
     19745    cggsvp_
     19746    ^
     19747    2 errors generated.
  >> 19748    make[3]: *** [lapacke_cggsvp_work.o] Error 1
     19749    make[3]: *** Waiting for unfinished jobs....
  >> 19750    lapacke_dggsvp_work.c:48:9: error: implicit declaration of function 'dggsvp_' is invalid in C99 [-Werror,-Wimplicit-function-declaratio
              n]
     19751            LAPACK_dggsvp( &jobu, &jobv, &jobq, &m, &p, &n, a, &lda, b, &ldb, &tola,
     19752            ^
     19753    ../include/lapack.h:3763:23: note: expanded from macro 'LAPACK_dggsvp'
     19754    #define LAPACK_dggsvp LAPACK_GLOBAL(dggsvp,DGGSVP)
     19755                          ^
     19756    ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'

     ...

     19778    ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'
     19779    #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
     19780                                          ^
     19781    <scratch space>:95:1: note: expanded from here
     19782    dggsvp3_
     19783    ^
  >> 19784    lapacke_dggsvp_work.c:127:9: error: implicit declaration of function 'dggsvp_' is invalid in C99 [-Werror,-Wimplicit-function-declarati
              on]
     19785            LAPACK_dggsvp( &jobu, &jobv, &jobq, &m, &p, &n, a_t, &lda_t, b_t,
     19786            ^
     19787    ../include/lapack.h:3763:23: note: expanded from macro 'LAPACK_dggsvp'
     19788    #define LAPACK_dggsvp LAPACK_GLOBAL(dggsvp,DGGSVP)
     19789                          ^
     19790    ../include/lapacke_mangling.h:12:39: note: expanded from macro 'LAPACK_GLOBAL'
     19791    #define LAPACK_GLOBAL(lcname,UCNAME)  lcname##_
     19792                                          ^
     19793    <scratch space>:229:1: note: expanded from here
     19794    dggsvp_
     19795    ^
     19796    2 errors generated.
  >> 19797    make[3]: *** [lapacke_dggsvp_work.o] Error 1
  >> 19798    make[2]: *** [lapacke] Error 2
  >> 19799    make[1]: *** [lapackelib] Error 2
  >> 19800    make: *** [netlib] Error 2

I assume this to be a problem with missing includes. At least I ran into a similar issue with building llvmlite which fails due to a missing #include_next <stdlib.h> and googling the combined error set from these two failures ends up with a lot of forum discussion regarding the Xcode10->Xcode11 switch.

Has anyone (recently) successfully build OpenBLAS with the system compiler on MacOSX?
Are you aware of this kind of build error?

Any help would be deeply appreciated. Spack should not do anything besides the normal make && make install PREFIX=. I'm currently running a test build with the current develop branch

[martin-frbg]

This was actually an error in Reference-LAPACK (bundled with OpenBLAS) that got uncovered by xcode 12 some days ago - issue #2805 and fix in #2808 (if you append .diff to the url of the pull request github shows it in diff format suitable for patching - the easiest solution is probably to just download the current version of the file in the develop branch - https://github.com/xianyi/OpenBLAS/blob/develop/lapack-netlib/LAPACKE/include/lapack.h

[healther]

I assume this would also fix things for older releases (assuming that the patch applies) and that it will be fixed in the next releases correct?

[martin-frbg]

Certainly.