Remove whitespace in addBodyClass($className) #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if no result from $this->getBodyClass() output just classname instead of null+whitespace+classname
colinmollenhour
approved these changes
Jan 29, 2019
kkrieger85
approved these changes
Mar 5, 2019
sreichel
approved these changes
Mar 5, 2019
LeeSaferite
approved these changes
Mar 26, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
…lass() If $this->getBodyClass() returns nothing a superfluous whitespace is generated in classname output.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
…lass() If $this->getBodyClass() returns nothing a superfluous whitespace is generated in classname output.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
…lass() If $this->getBodyClass() returns nothing a superfluous whitespace is generated in classname output.
|
Files affected by this commit: in app/design/frontend/rwd/default/template/page in app/design/frontend/base/default/template/page |
kiatng
added a commit
to kiatng/magento-lts
that referenced
this pull request
Feb 14, 2020
…penMage#594 Remove whitespace in addBodyClass($className)OpenMage#594
Flyingmana
pushed a commit
that referenced
this pull request
Feb 14, 2020
colinmollenhour
pushed a commit
that referenced
this pull request
Feb 21, 2020
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
…lass() If $this->getBodyClass() returns nothing a superfluous whitespace is generated in classname output.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
…template files Side effect of OpenMage#594
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
…template files Side effect of OpenMage#594
Flyingmana
pushed a commit
that referenced
this pull request
Sep 28, 2021
spinsch
pushed a commit
to spinsch/magento-lts
that referenced
this pull request
Oct 13, 2021
* Insert whitespace in class name for styling to work. See pull request OpenMage#594 Remove whitespace in addBodyClass($className)OpenMage#594 * Fix file delete in customer attribute of `frontend_input` = 'file'.
randallelliott714
added a commit
to randallelliott714/magento
that referenced
this pull request
Oct 18, 2022
… #594 Remove whitespace in addBodyClass($className)OpenMage/magento-lts#594 (#898)
randallelliott714
added a commit
to randallelliott714/magento
that referenced
this pull request
Oct 18, 2022
* Insert whitespace in class name for styling to work. See pull request #594 Remove whitespace in addBodyClass($className)OpenMage/magento-lts#594 * Fixed typo in data type.
randallelliott714
added a commit
to randallelliott714/magento
that referenced
this pull request
Oct 18, 2022
* Insert whitespace in class name for styling to work. See pull request #594 Remove whitespace in addBodyClass($className)OpenMage/magento-lts#594 * Fix file delete in customer attribute of `frontend_input` = 'file'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove whitespace that is generated in body class string.
if no result from $this->getBodyClass() output just classname instead of null+whitespace+classname
E.g.
<body class=" classnames">Fixed Result:
<body class="classnames">