Skip to content

Fixed null deprecation array_keys in Multishipping. #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Fixed null deprecation array_keys in Multishipping. #4418

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
930308a
Fixed null deprecation array_keys in Multishipping.
kiatng Dec 16, 2024
bdf918e
Update app/code/core/Mage/Core/Model/Session.php
kiatng Dec 16, 2024
ad0ac2b
Merge branch 'main' into nd_getOrderIds
kiatng Dec 16, 2024
2235330
Merge branch 'main' into nd_getOrderIds
sreichel Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/code/core/Mage/Core/Model/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
* @method $this setCurrencyCode(string $value)
* @method $this setFormData(array $value)
* @method int getJustVotedPoll()
* @method array getOrderIds()
* @method $this setOrderIds(array $value)
* @method $this setJustVotedPoll(int $value)
* @method $this setLastUrl(string $value)
Expand Down Expand Up @@ -75,4 +74,9 @@ public function validateFormKey($formKey)
{
return ($formKey === $this->getFormKey());
}

public function getOrderIds(bool $clear = false): array
{
return $this->getData('order_ids', $clear) ?? [];
}
}
Loading