Skip to content

Conversation

@davidhiendl
Copy link
Contributor

Description (*)

Fix a regression introduced with the EAV overhaul where the product comparison in the frontend does not sort the attributes by group anymore.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Compare 2 products
  2. Move attributes in attribute sets around and observe the frontend order

…nger sorted correctly by attribute group order in attribute comparison
@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: Eav Relates to Mage_Eav labels Jul 1, 2024
@addison74
Copy link
Contributor

It tested this PR and it fixes the issue. The attributes are listed in the comparison window in their order set up by the user.

@fballiano fballiano changed the title fix regression introduced in #2993 where attributes are no longer sorted correctly by attribute group order in attribute comparison Fixed regression introduced in #2993 where attributes are no longer sorted correctly by attribute group order in attribute comparison Jul 1, 2024
@fballiano fballiano merged commit 433796a into OpenMage:main Jul 1, 2024
@addison74 addison74 linked an issue Jul 1, 2024 that may be closed by this pull request
@sreichel sreichel added the bug label Feb 4, 2025
@sreichel
Copy link
Contributor

sreichel commented Feb 4, 2025

@all-contributors add @davidhiendl code

@allcontributors
Copy link
Contributor

@sreichel

@davidhiendl already contributed before to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Component: Catalog Relates to Mage_Catalog Component: Eav Relates to Mage_Eav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong attributes order in comparison window

4 participants