Avoided calling getBackendModelByFieldConfig with empty field #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinbeaty
approved these changes
Apr 7, 2023
sreichel
approved these changes
Apr 7, 2023
elidrissidev
approved these changes
Apr 7, 2023
|
This needs to be backported to |
|
merge and cherrypicked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you open the backend and go to System -> configuration -> advanced -> advanced and just hit save, you'll see this error:
Uncaught TypeError: Argument 1 passed to Mage_Adminhtml_Helper_Config::getBackendModelByFieldConfig() must be an instance of Varien_Simplexml_Element, bool given, called in app/code/core/Mage/Adminhtml/Model/Config/Data.php on line 141This was introduced in #2945
With this PR we make sure not to call
$helper->getBackendModelByFieldConfig($fieldConfig)if we don't have any fieldConfig.After applying the PR, hit save and it works as expected.