Skip to content

Fixed monthly report dates (date was 1970) #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fixed monthly report dates (date was 1970) #3126

merged 1 commit into from
Apr 3, 2023

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Mar 31, 2023 •
edited
Loading

Description (*)

I dont see what changed with zf1 ... :(

Zend_Date::ISO_8601 expects a date like 2014-05-02, but for monthly reports the given date is only 2014-05.

Edit: Shardj/zf1-future@c7a5cf6#diff-fe1df84ebe2100899bfee24bd49ccecc97ee11538d93723a69632a9f9e5c021bR2045-R2059

Related Pull Requests

  1. See Replace lib/Zend with shardj/zf1-future 🚀  #2827

Fixed Issues (if relevant)

  1. Fixes Invalid report date #3122

Manual testing scenarios (*)

  1. open Sales -> Order reports
  2. monthly period

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Mar 31, 2023
@sreichel sreichel marked this pull request as draft March 31, 2023 02:52
@sreichel sreichel marked this pull request as ready for review March 31, 2023 02:52
@sreichel sreichel changed the title Fixed monthly sales reports Fixed monthly report dates Mar 31, 2023
@sreichel sreichel requested a review from elidrissidev April 2, 2023 08:13
@sreichel
Copy link
Contributor Author

sreichel commented Apr 2, 2023

Dont think its an issue with OpenMage ... Shardj/zf1-future#339

fballiano
fballiano approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@fballiano fballiano merged commit 699d5ac into OpenMage:1.9.4.x Apr 3, 2023
fballiano pushed a commit that referenced this pull request Apr 3, 2023
@sreichel @fballiano
Fixed monthly sales reports (date was 1970) (#3126)
982c597
@fballiano
Copy link
Contributor

merged and v20ed

@fballiano fballiano changed the title Fixed monthly report dates Fixed monthly report dates (date was 1970) Apr 3, 2023
@sreichel sreichel deleted the hotfix/invalid-date branch April 3, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiatng kiatng kiatng approved these changes

@elidrissidev elidrissidev Awaiting requested review from elidrissidev

+1 more reviewer

@fballiano fballiano fballiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Adminhtml Relates to Mage_Adminhtml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid report date

3 participants

@sreichel @fballiano @kiatng