RWD theme: Focus on the search field when clicking on the search button #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
reviewed
Mar 29, 2023
Co-authored-by: Shyim <[email protected]>
fballiano
commented
Mar 29, 2023
fballiano
commented
Mar 29, 2023
fballiano
commented
Mar 29, 2023
elidrissidev
approved these changes
Mar 29, 2023
FredericMartinez
approved these changes
Mar 29, 2023
|
@kiatng @addison74 what do you think about this? |
|
I haven't abandoned the ship. Unfortunately, the last month came with major changes in my life for which I was not prepared. I am trying to recover mentally, even though it's overwhelming. I think that OpenMage should be rethought as a project based on sponsorships and thus a permanent maintenance team would have been built to work dedicatedly without any periods of inactivity. |
|
@addison74 sorry to head that :-( wish you the best |
kiatng
approved these changes
Apr 3, 2023
fballiano
added a commit
that referenced
this pull request
Apr 3, 2023
…on (#3095) Co-authored-by: Shyim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the RWD theme, mobile version, when you click the search button here:
it shows the search field but you've to tap on it in order to be able to write the search query.
I think this is not the best behaviour, when clicking on the search button I'd like the search field to be shown with the focus already in the field, so that I can directly start to type without another (unnecessary) click.
This PR adds a few lines of js in order to implement that.
Note: there's a try/catch just in case a custom there doesn't have the #search field (although it's very unlikely).