EAV Config Cache revert return empty attribute model #3074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the same context due to entity type attribute collection being reused
…ollection and for code reuse instead
…d' into eav_config_cache_multi_scope_load
…turns an empty model if attribute does not exist
fballiano
reviewed
Mar 9, 2023
fballiano
reviewed
Mar 9, 2023
fballiano
approved these changes
Mar 9, 2023
addison74
approved these changes
Mar 9, 2023
This was
linked to
issues
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in #2993 changed the behaviour of
getAttributeto returnfalseinstead of an empty model. While this might be a more desirable return type it breaks some behavior that relies on it. This PR reverts that change and returns a fresh empty model whengetAttribute("non_existent_code")is called.Related Pull Requests
#2993
Fixed Issues (if relevant)