Fixed incorrect datetime in block, ref #1525

[sreichel]

Description (*)

#1525 was added to v20 only, because it was a BC breaking change. This PR solves that issue w/o changing existing methods signature. (code from 1525)

Not sure about this change ... changing ...

if (!($date instanceof Zend_Date) && $date && !strtotime($date)) {
    return '';
}
if (is_null($date)) {
    $date = Mage::app()->getLocale()->date(Mage::getSingleton('core/date')->gmtTimestamp(), null, null);

Related Pull Requests

1. See Fixed incorrect datetime in block. #1525

Fixed Issues (if relevant)

1. Closes Backported #1525 #2850

Manual testing scenarios (*)

1. see related PR
2. ...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[sreichel]

possibly related to #2739

[fballiano]

@kiatng what do you think about this?

[kiatng]

This is a better fix of the original issue.

Is this going to be in v20? If it is and if there are custom code in the wild that uses $useTimezone in formatDate(), it'll produce unexpected result. But BC in v20 is tolerable. Is it worthwhile to add a note in README for BC in v20?

[kiatng]

Test result comparing original v19 formatDate($date) and formatTimezoneDate($date):

1. $date = '2022-12-28 13:00:00';: both return "28/12/2022 21:00", correctly converted to local time.
2. $date = null;: both return "28/12/2022 03:04" (GMT time)
3. $date = '';: both return "28/12/2022 11:26", local time.
4. $date = '2022-12-28 13:00:00'; $date = new Zend_Date($date);: both return "28/12/2022 13:00", correct because timezone in Zend_Date was not set.
5. $date = '2022-12-28 13:00:00'; $date = strtotime($date);: formatDate() -> "", formatTimezoneDate() -> "28/12/2022 21:00". I think result of formatTimezoneDate() is preferable.

[sreichel]

@kiatng thanks. Would be nice to had a unit-test here.

[kiatng]

Should not have serious effect in v20.

[fballiano]

so the idea is to port it to v20 right? otherwise it would be actually worse to maintain

[sreichel]

Add @kiatng fix to v19 and port/replace it to v20 was my plan ... ❔

[addison74]

Closing this PR was a wrong decision. It was a better fix for that issue.

[sreichel]

@addison74 there is a follow-up PR. (#2940)