phpstan: Sitemap, Newsletter, ...

[sreichel]

Description (*)

Some small updates.

Edit: ignore some errors and remove them from baseline.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[tmotyl]

What is the gain from ignoring errors?
Are they all false positives?

[sreichel]

@tmotyl its to much noise at the moment.

Some are false positive or go away when underlying errors are fixed.

I'll re-add them later.

[tmotyl]

Roger!
Thanks for taking care!

[fballiano]

can't auto merge to 20.0 because of conflicts

[sreichel]

What is auto-merge?

(Btw ... if you have conflicts with baseline file ... ignore them and merge, then rebuild baseline and amend last commit.)

[fballiano]

I meant cherry picking it to 20.0

[fballiano]

I had an old command to regenerate the baseline, it created a .github/phpstan-baseline.neon file but now that's pushed it doesn't allow me to re-ament it.

hate this workflow

[fballiano]

but in 20.0 there are anyway all of these files

so probably we can leave it as it is for now

[sreichel]

but in 20.0 there are anyway all of these files

Yep. #2765 was added one day after release. Should be fixed in next release ;)

[sreichel]

What is the gain from ignoring errors? Are they all false positives?

@tmotyl Maybe you can check this .... it seems neither phpstorm nor phpstan works correctly for Mage::app()->someMethod(). (this causes some of false positives)

[tmotyl]

@sreichel can you make an issue at https://github.com/macopedia/phpstan-magento1 with some info how to reproduce it?
When I type Mage::app()-> in phpstorm, I'm getting correct method proposals.

[sreichel]

@sreichel can you make an issue at https://github.com/macopedia/phpstan-magento1 with some info how to reproduce it? When I type Mage::app()-> in phpstorm, I'm getting correct method proposals.

I'll do.

Mhh, i get no proposals for Mage::app() and also have no correct return value. E.g.

$store = Mage::app()->getStore();
if (!$store) { # false psoitive here ...

Linux, PhpStorm 2022.2.2 Build #PS-222.4167.33, built on September 15, 2022

[tmotyl]

PhpStorm 2022.3 here.
getStore can return null, so the check is needed

[sreichel]

getStore can return null, so the check is needed

This is right, but i have no return type. For phpstan this check is always true|false ("#Negated boolean expression ...")

Edit: Cleared phpstorm cache and auto-complete works again. Will check phpstan later,