Skip to content

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 12, 2022

Description (*)

#1812 was closed w/o merging anything. New try, with smaller PRs.

Related Pull Requests

  1. See Some changes for compatibility with PHP 8.1 #1812
  2. See Replaced bundled Zend Framework with zf1-future #2787

Fixed Issues (if relevant)

Deprecated functionality: PDOStatement::fetch(): Passing null to parameter #2 ($cursorOrientation) of type int is deprecated in lib/Zend/Db/Statement/Pdo.php on line 254

Questions or comments

ZF1F uses same code.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok in the meanwhile ;-)

@sreichel
Copy link
Contributor Author

sreichel commented Dec 15, 2022

Thanks :)

When you want to test #1812, you had to patch some files everytime. (this one, or the merge addslashes fix ...) This makes it a bit easier :)

@sreichel sreichel requested a review from luigifab December 17, 2022 05:05
@sreichel
Copy link
Contributor Author

This blocks other tests. Please approve.

@fballiano fballiano merged commit 21d66ed into OpenMage:1.9.4.x Dec 19, 2022
@sreichel sreichel deleted the fix/php8.1/pdo-fetch branch December 19, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: lib/* Relates to lib/* PHP 8.1 Related to PHP 8.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants