Skip to content

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 18, 2022

Description (*)

  • adds PHPCompatibility check
  • adds PHP-CS-Fixer to workflow
    • fixes last errors, not found by phpcs
  • updated PhpStan
    • updated to v1.9.2
    • removed experimental check and set default level to 5 (from 3 befor)
  • updated complete workflow (to run a bit faster)

Fixed Issues (if relevant)

  1. Closes Discussion: Consider using PHP CS Fixer and/or PHPStan #947

Related PR

  1. See Chore: Add Captainhook & PHPCS to composer require-dev and sample captainhook config #1264
  2. See Running a PHP code sniff against fresh install for PHP compatibility with PHP 7 shouldn't find errors. #1157
  3. See Phpstan: workflow update #2707

Manual testing scenarios (*)

php vendor/bin/php-cs-fixer fix --config=.github/php-cs-fixer-ruleset.php <path-to-files>

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

Signed-off-by: Sven Reichel <[email protected]>
Signed-off-by: Sven Reichel <[email protected]>
Signed-off-by: Sven Reichel <[email protected]>
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/* Component: Oauth Relates to Mage_Oauth Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: ProductAlert Relates to Mage_ProductAlert Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Tag Relates to Mage_Tag environment labels Nov 18, 2022
@sreichel sreichel changed the title Adde php-cs-fixer to workflow Add php-cs-fixer to workflow Nov 18, 2022
fballiano
fballiano previously approved these changes Nov 18, 2022
@sreichel sreichel changed the title Add php-cs-fixer to workflow Add php-cs-fixer & PHPCompatibility check to workflow Nov 19, 2022
@github-actions github-actions bot added the Component: lib/Varien Relates to lib/Varien label Nov 20, 2022
@github-actions github-actions bot added Mage.php Relates to app/Mage.php phpstan labels Nov 25, 2022
@sreichel sreichel mentioned this pull request Nov 25, 2022
4 tasks
@sreichel sreichel mentioned this pull request Nov 25, 2022
@github-actions github-actions bot added the Component: PaypalUk Relates to Mage_PaypalUk label Nov 28, 2022
@sreichel sreichel merged commit 7fe65ad into OpenMage:1.9.4.x Nov 29, 2022
@sreichel sreichel deleted the php-cs-fixer branch November 29, 2022 06:33
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 7fe65ad. ± Comparison against base commit 879caab.

@fballiano fballiano mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Install Relates to Mage_Install Component: lib/Mage Relates to lib/Mage Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: ProductAlert Relates to Mage_ProductAlert Component: Reports Relates to Mage_Reports Component: Rss Relates to Mage_Rss Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Sendfriend Relates to Mage_Sendfriend Component: Tag Relates to Mage_Tag Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget Component: Wishlist Relates to Mage_Wishlist composer Relates to composer.json environment Mage.php Relates to app/Mage.php phpstan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion: Consider using PHP CS Fixer and/or PHPStan

7 participants