- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 452
Add php-cs-fixer & PHPCompatibility check to workflow #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: Sven Reichel <[email protected]>
Signed-off-by: Sven Reichel <[email protected]>
Signed-off-by: Sven Reichel <[email protected]>
              
                    fballiano
  
              
              previously approved these changes
              
                  
                    Nov 18, 2022 
                  
              
              
            
            
      
     Merged
  
              
                    kiatng
  
              
              reviewed
              
                  
                    Nov 26, 2022 
                  
              
              
            
            
              
                    kiatng
  
              
              reviewed
              
                  
                    Nov 26, 2022 
                  
              
              
            
            
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
              
                    kiatng
  
              
              reviewed
              
                  
                    Nov 29, 2022 
                  
              
              
            
            
Co-authored-by: Ng Kiat Siong <[email protected]>
              
                    kiatng
  
              
              approved these changes
              
                  
                    Nov 29, 2022 
                  
              
              
            
            
              
                    addison74
  
              
              approved these changes
              
                  
                    Nov 29, 2022 
                  
              
              
            
            
      
     Merged
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    Component: Adminhtml
  Relates to Mage_Adminhtml 
  
    Component: Api
  PageRelates to Mage_Api 
  
    Component: Api2
  Relates to Mage_Api2 
  
    Component: Authorizenet
  Relates to Mage_Authorizenet 
  
    Component: Backup
  Relates to Mage_Backup 
  
    Component: Bundle
  Relates to Mage_Bundle 
  
    Component: Catalog
  Relates to Mage_Catalog 
  
    Component: CatalogIndex
  Relates to Mage_CatalogIndex 
  
    Component: CatalogInventory
  Relates to Mage_CatalogInventory 
  
    Component: CatalogSearch
  Relates to Mage_CatalogSearch 
  
    Component: Centinel
  Relates to Mage_Centinel 
  
    Component: Checkout
  Relates to Mage_Checkout 
  
    Component: Cms
  Relates to Mage_Cms 
  
    Component: ConfigurableSwatches
  Relates to Mage_ConfigurableSwatches 
  
    Component: Core
  Relates to Mage_Core 
  
    Component: Customer
  Relates to Mage_Customer 
  
    Component: Dataflow
  Relates to Mage_Dataflow 
  
    Component: Downloadable
  Relates to Mage_Downloadable 
  
    Component: Eav
  Relates to Mage_Eav 
  
    Component: ImportExport
  Relates to Mage_ImportExport 
  
    Component: Index
  Relates to Mage_Index 
  
    Component: Install
  Relates to Mage_Install 
  
    Component: lib/Mage
  Relates to lib/Mage 
  
    Component: lib/Varien
  Relates to lib/Varien 
  
    Component: lib/*
  Relates to lib/* 
  
    Component: Oauth
  Relates to Mage_Oauth 
  
    Component: Page
  Relates to Mage_Page 
  
    Component: Paygate
  Relates to Mage_Paygate 
  
    Component: Payment
  Relates to Mage_Payment 
  
    Component: PayPal
  Relates to Mage_Paypal 
  
    Component: PaypalUk
  Relates to Mage_PaypalUk 
  
    Component: ProductAlert
  Relates to Mage_ProductAlert 
  
    Component: Reports
  Relates to Mage_Reports 
  
    Component: Rss
  Relates to Mage_Rss 
  
    Component: Rule
  Relates to Mage_Rule 
  
    Component: Sales
  Relates to Mage_Sales 
  
    Component: SalesRule
  Relates to Mage_SalesRule 
  
    Component: Sendfriend
  Relates to Mage_Sendfriend 
  
    Component: Tag
  Relates to Mage_Tag 
  
    Component: Usa
  Relates to Mage_Usa 
  
    Component: Weee
  Relates to Mage_Weee 
  
    Component: Widget
  Relates to Mage_Widget 
  
    Component: Wishlist
  Relates to Mage_Wishlist 
  
    composer
  Relates to composer.json 
  
    environment
  
    Mage.php
  Relates to app/Mage.php 
  
    phpstan
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description (*)
phpcsFixed Issues (if relevant)
Related PR
Manual testing scenarios (*)
php vendor/bin/php-cs-fixer fix --config=.github/php-cs-fixer-ruleset.php <path-to-files>Contribution checklist (*)