Skip to content

Require a parent category to add a new sub category #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2022
Merged

Require a parent category to add a new sub category #2716

merged 3 commits into from
Dec 1, 2022

Conversation

@luigifab
Copy link
Contributor

@luigifab luigifab commented Nov 16, 2022 •
edited
Loading

Description

Go to Catalog > Categories.

  • click on "Add Subcategory" without selecting a parent, this is now not possible
  • select any category and click on "Add Subcategory"
  • don't save and click on "Add Root Category", selected category is now unselected

image

This is an improved extract of #1379.

OpenMage 20.0.17 / PHP 8.0.25

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@luigifab
Require a parent category to add a new sub category
bd81ebf 
Unselect current category when adding a new root category
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template translations Relates to app/locale labels Nov 16, 2022
fballiano
fballiano reviewed Dec 1, 2022
View reviewed changes
luigifab and others added 2 commits December 1, 2022 19:31
@luigifab @fballiano
Text update
701a975 
Co-authored-by: Fabrizio Balliano <[email protected]>
@luigifab @fballiano
Text update
8b08a5f 
Co-authored-by: Fabrizio Balliano <[email protected]>
@fballiano fballiano merged commit bcddc15 into OpenMage:1.9.4.x Dec 1, 2022
@sreichel sreichel mentioned this pull request Dec 1, 2022
Closed
10 tasks
@luigifab luigifab deleted the no-category-without-parent branch December 2, 2022 08:42
fballiano pushed a commit that referenced this pull request Dec 19, 2022
@luigifab @fballiano
Adminhhtml: A parent category is not required in order to add a sub c…
92a9e9d 
…ategory (#2716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sreichel sreichel sreichel approved these changes

+1 more reviewer

@fballiano fballiano fballiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template translations Relates to app/locale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luigifab @fballiano @sreichel