Skip to content

Conversation

@luigifab
Copy link
Contributor

@luigifab luigifab commented Nov 10, 2022

Description

This PR is useless, it add $order->getInvoicesCollection() as an alias for getInvoiceCollection().
Like getShipmentsCollection(), getCreditmemosCollection() and getTracksCollection().

OpenMage 20.0.16 / PHP 8.0.25

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Nov 10, 2022
elidrissidev
elidrissidev previously approved these changes Nov 10, 2022
@fballiano
Copy link
Contributor

I've checked in the codebase and all of the "getSomethingCollection" method has a singular naming, so I wouldn't merge this specific PR since it would be the exception, sorry.

@elidrissidev
Copy link
Member

I've checked in the codebase and all of the "getSomethingCollection" method has a singular naming

I see the opposite:

public function getInvoiceCollection()

public function getShipmentsCollection()

public function getCreditmemosCollection()

public function getTracksCollection()

@fballiano
Copy link
Contributor

Schermata 2022-11-11 alle 09 17 13

Schermata 2022-11-11 alle 09 17 24

I guess it's random then :-D

elidrissidev
elidrissidev previously approved these changes Nov 29, 2022
sreichel
sreichel previously approved these changes Nov 30, 2022
@sreichel sreichel dismissed stale reviews from elidrissidev and themself via 2b1ee4f November 30, 2022 02:17
@sreichel
Copy link
Contributor

Fixed conflict.

@sreichel sreichel merged commit a6f8323 into OpenMage:1.9.4.x Nov 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a6f8323. ± Comparison against base commit 5e04bdb.

@luigifab luigifab deleted the invoices-collection branch December 1, 2022 08:10
fballiano pushed a commit that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Sales Relates to Mage_Sales

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants