Skip to content

Fixed admin grid filter #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

Fixed admin grid filter #2537

merged 1 commit into from
Sep 1, 2022

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 1, 2022 •
edited
Loading

Description (*)

Fixed admin grid filter.

Related Pull Requests

Manual testing scenarios (*)

  1. go to customer reviews
  2. filter by customer group

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel
Fixed admin grid filter
f3cc348 
E.g. customer review: filter by customer group
@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Sep 1, 2022
kiatng
kiatng approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@fballiano fballiano merged commit 4db847a into OpenMage:1.9.4.x Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 4db847a. ± Comparison against base commit 0d7b9d0.

@sreichel sreichel deleted the hotfix/admin-grid-filter branch September 1, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiatng kiatng kiatng approved these changes

+1 more reviewer

@fballiano fballiano fballiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Adminhtml Relates to Mage_Adminhtml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sreichel @fballiano @kiatng