Skip to content

[PHP 8] Fix TypeError when calling round() with a string argument #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2022
Merged

[PHP 8] Fix TypeError when calling round() with a string argument #2193

merged 1 commit into from
Jun 4, 2022

Conversation

@elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Jun 4, 2022 •
edited
Loading

Fix a TypeError in PHP 8 and above when calling round with a mismatching argument type.

Related Pull Requests

#1403 fixed this error in the past but missed three usages.

Manual testing scenarios (*)

  1. Make sure DHL shipping method is enabled from System -> Configuration -> Shipping Methods -> DHL -> Enabled for Checkout
  2. Try creating an Order from Admin, when clicking "Get shipping methods and rates" the request returns 500 error and no shipping methods are shown.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Usa Relates to Mage_Usa label Jun 4, 2022
@elidrissidev elidrissidev mentioned this pull request Jun 4, 2022
Merged
3 tasks
@fballiano fballiano merged commit 3811f8b into OpenMage:1.9.4.x Jun 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 3811f8b. ± Comparison against base commit b89b9a3.

@elidrissidev elidrissidev deleted the elidrissidev-patch-1 branch June 4, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addison74 addison74 addison74 approved these changes

+1 more reviewer

@fballiano fballiano fballiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Usa Relates to Mage_Usa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elidrissidev @fballiano @addison74