Skip to content

Rise Phpstan level 2, fix some issues #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 25, 2022
Merged

Rise Phpstan level 2, fix some issues #2146

merged 5 commits into from
May 25, 2022

Conversation

@tmotyl
Copy link
Contributor

@tmotyl tmotyl commented May 24, 2022 •
edited
Loading

Description (*)

This PR rises phpstan level to 2, and fixes some issues along the way.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

For easier review, I've grouped similar changes per commit.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Install Relates to Mage_Install Component: Log Relates to Mage_Log Component: Paygate Relates to Mage_Paygate Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Usa Relates to Mage_Usa composer Relates to composer.json environment labels May 24, 2022
@tmotyl tmotyl force-pushed the phpstan-level-2 branch from 00ce7ae to 71626b1 Compare May 24, 2022 20:43
kiatng
kiatng reviewed May 25, 2022
View reviewed changes
@fballiano fballiano merged commit 299497e into OpenMage:1.9.4.x May 25, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 299497e. ± Comparison against base commit c0d12f4.

@sreichel
Copy link
Contributor

@tmotyl thanks for working on this :)

@sreichel sreichel mentioned this pull request Jul 24, 2022
Merged
4 tasks
@sreichel
Copy link
Contributor

sreichel commented Aug 9, 2022

Raised to level 2 and left 7k lines of ignored errors ....

... here we go :P

(Thanks!)

@sreichel
Copy link
Contributor

With next commits the baseline file is "only" around 3k lines ... "only" 600 more errors to check ... :P

@tmotyl
Copy link
Contributor Author

tmotyl commented Sep 19, 2022

@sreichel sounds like its time to go for level 3 or 4

@sreichel
Copy link
Contributor

sreichel commented Sep 19, 2022 •
edited
Loading

@tmotyl no, not really. Still 3k lines ... I'd like to recude this to below 1k before change to level 3.

... why not ...:) 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiatng kiatng kiatng left review comments

@addison74 addison74 addison74 approved these changes

+1 more reviewer

@fballiano fballiano fballiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Install Relates to Mage_Install Component: Log Relates to Mage_Log Component: Paygate Relates to Mage_Paygate Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Usa Relates to Mage_Usa composer Relates to composer.json environment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmotyl @sreichel @fballiano @kiatng @addison74