Skip to content

Add unit tests for security helper validateAgainstBlockMethodBlacklist and provide composer.lock #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2022
Merged

Add unit tests for security helper validateAgainstBlockMethodBlacklist and provide composer.lock #2058

merged 1 commit into from
Apr 26, 2022

Conversation

@tmotyl
Copy link
Contributor

@tmotyl tmotyl commented Apr 26, 2022 •
edited
Loading

Description (*)

This PR does 3 things:

  1. Adding unit tests for security helper
  2. provide composer.lock to stabilize openmage builds (so new versions of dependencies are not breaking PR builds)
  3. updates phpstan baseline to match phpstan 1.6

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@tmotyl tmotyl force-pushed the securityhelper_unit_tests branch from 92a51a4 to 6d4b8b1 Compare April 26, 2022 09:28
@tmotyl tmotyl force-pushed the securityhelper_unit_tests branch from 6d4b8b1 to 24d9874 Compare April 26, 2022 09:32
@github-actions github-actions bot added the composer Relates to composer.json label Apr 26, 2022
@tmotyl
Add unit tests for security helper and provide composer.lock
56d033f 
This change also includes change in phpstan baseline because new
phpstan version 1.6 was released
@tmotyl tmotyl force-pushed the securityhelper_unit_tests branch from 24d9874 to 56d033f Compare April 26, 2022 09:42
@tmotyl tmotyl changed the title Add unit tests for security helper validateAgainstBlockMethodBlacklist Add unit tests for security helper validateAgainstBlockMethodBlacklist and provide composer.lock Apr 26, 2022
@mark-netalico mark-netalico self-requested a review April 26, 2022 11:10
@Flyingmana Flyingmana merged commit c85fdef into OpenMage:1.9.4.x Apr 26, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit c85fdef. ± Comparison against base commit 7630ca2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark-netalico mark-netalico mark-netalico approved these changes

+2 more reviewers

@Flyingmana Flyingmana Flyingmana approved these changes

@Sdfendor Sdfendor Sdfendor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

composer Relates to composer.json environment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmotyl @Flyingmana @mark-netalico @Sdfendor