Skip to content

Trim trailing whitespace #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Trim trailing whitespace #1846

merged 1 commit into from
Oct 4, 2021

Conversation

@luigifab
Copy link
Contributor

@luigifab luigifab commented Oct 2, 2021

This useless PR trim trailing white space of all PHP and XML files in lib/Zend/ directory and subdirectories (to reduce number of changes of #1832).

@luigifab luigifab mentioned this pull request Oct 2, 2021
Closed
4 tasks
luigifab
luigifab commented Oct 2, 2021
View reviewed changes
Copy link
Contributor Author

@luigifab luigifab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github says Whitespace-only changes. for all files. I loving it.

@Flyingmana Flyingmana merged commit 3ef5922 into OpenMage:1.9.4.x Oct 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 3ef5922. ± Comparison against base commit 7a039a6.

@luigifab luigifab deleted the trim-ending-whitespace-zend branch October 4, 2021 06:17
spinsch pushed a commit to spinsch/magento-lts that referenced this pull request Oct 13, 2021
@luigifab @spinsch
Trim trailing whitespace (OpenMage#1846)
c798ad5
@sreichel sreichel mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiatng kiatng kiatng approved these changes

+1 more reviewer

@Flyingmana Flyingmana Flyingmana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: lib/* Relates to lib/*

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luigifab @Flyingmana @kiatng