Skip to content

Conversation

@kiatng
Copy link
Contributor

@kiatng kiatng commented Dec 18, 2020

Description (*)

See M2 Issue #16174

Related Pull Requests

See M2 PR #16412.

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. Suppose we want to place Recurring Profiles (beta) in customer page before Billing Agreements:
    image
  2. Change line 112 here to return 'customer_edit_tab_recurring_profile';
  3. Result is:
    image
  4. With the fix in this PR:
    image

Questions or comments

I need to modify the fix in M2 to correctly order the tabs in the test scenario describes above.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@kiatng kiatng added bug Component: Adminhtml Relates to Mage_Adminhtml labels Dec 18, 2020
@kiatng kiatng marked this pull request as draft January 5, 2021 06:20
@kiatng kiatng marked this pull request as ready for review July 13, 2021 07:46
@fballiano fballiano merged commit a662cf9 into OpenMage:1.9.4.x May 18, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
7 runs  5 ✔️ 2 💤 0 ❌

Results for commit a662cf9.

@kiatng kiatng deleted the admin_tabs_bug branch February 27, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Component: Adminhtml Relates to Mage_Adminhtml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants