Added a libfreenect2_api export macro - to apply __declspec(dllexport) i...

[larshg]

...nfront of all classes that is used from the library libfreenect2.

If they are not specified VS won't generate a .lib file and protonect will give linking errors.

[christiankerl]

could you please rename libfreenectExport.h to libfreenect2_export.h to be consistent with the naming of the other headers?

[larshg]

I have noticed that this export macro is already defined the in the header filer under libfreenect2/include/libfreenect2.h - but this file is not used anywhere, as far as I can see - is this a leftover from earlier - should it be removed?

[christiankerl]

hm, actually that is the C API, which should wrap the C++ API, but nobody implemented it so far ;)

[larshg]

Ahh. I have renamed the header file and corrected accordingly.

[christiankerl]

some more changes:

• in libfreenect2_export.h the license header is missing. could you add it, please?
• in tinythread.h the include of libfreenect2_export.h uses a backslash, but it has to be a slash

[larshg]

Updated accordingly.

[feiyuyu]

Is this problem solved? I try this new version but still no .lib file generate and the run time error shows that it still needs a libfreenect.lib

[larshg]

Have you merged this pull-request and compiling using VS?
Then it should work.

Try look at the LIBFREENECT2_API macro and see what it is defined as. It should be something like __dllspec export - if not, do you have a compiler flag/define '_win32' - if not, this might be the problem and we might need to add a or statement or perhaps add something in the cake files.

[larshg]

Should I just close this pull request, as it is handled in #103 ?