Add accessors for the various depth tables. #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that's ok with me, if that's your preference. It does imply copying the data, but since this is one-off (and not that big) that doesn't bother me. I can do that if you prefer. |
|
Alright then keep the pointers. There is no point in doing the extra copy. |
|
Comment addressed. please take another look. thanks! |
|
Looks fine. Build tests fine. |
xlz
added a commit
that referenced
this pull request
Feb 3, 2016
dump: Add accessors for the various depth tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #551
@xlz I had to add
size_t *lento the accessors since there is no good way to get the lengths out of the library without moving around things and declaring a new constant forsizeof(P0TableResponse)Let me know if you have a preferred alternate approach.