Refactor processMeasurementTriple #404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased to new master |
|
Individual commits have really messy diffs so I didn't look. I looked at the whole diff, and did not find any errors. Seems equivalent to me. |
| m_out[2] = tmp5; // ir amplitude | ||
| m_out[0] = ir_image_a; // ir image a | ||
| m_out[1] = ir_image_b; // ir image b | ||
| m_out[2] = ir_amplitude; // ir amplitude |
There was a problem hiding this comment.
These comments // ir amplitude are redundant now.
|
Individual commits are very small refactor steps that I did to ensure I wouldn't break current behaviour. For this branch, I additionally removed or shortened most comments, eliminated cond0 (replacing it with its value), and renamed "cond1" to "saturated". Finally, merged all commits into 1 "refactor" patch. |
|
Manually merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of simple refactor steps to convert the function into a more readable version