-
Notifications
You must be signed in to change notification settings - Fork 770
Fix class LogMessage link error in windows and compile error #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yuanmingze
commented
Sep 11, 2015
- Fix class LogMessage link error in windows
- Fix logging.cpp's compiling error
- When exit libfreenect2::CpuDepthPacketProcessor::process is called but listener_ pointer is NULL. Adding checking to listener_
- First time deleting not alloced memmory pointer buffer_ will fail.When create Mat buffer_ set NULL
…ECT2_API to LogMessage and getShortName to fix link error.Adding return to logging.cpp's stopTiming function to fix compile error
Looks sensible to me - @xlz @christiankerl any comments? |
|
OK. The correct fix for this is from a later PR https://github.com/xlz/libfreenect2/commit/ca75ebafabd255a4736fb6179fb786c1e58b3272 Change viewer.h: #include <libfreenect2/config.h>
#include <libfreenect2/frame_listener.hpp>
-#include <libfreenect2/logging.h>
#include <string>
#include <map>
#include <../src/flextGL.h>
+#include <iostream>
#include <GLFW/glfw3.h>
struct Vertex
@@ -189,7 +189,7 @@ struct ShaderProgram : public WithOpenGLBindings
{
gl()->glGetShaderInfoLog(vertex_shader, sizeof(error_buffer), NULL, error_buffer);
- LOG_ERROR << "failed to compile vertex shader!" << std::endl << error_buffer;
+ std::cerr << "failed to compile vertex shader!" << std::endl << error_buffer;
}
gl()->glCompileShader(fragment_shader);
@@ -199,7 +199,7 @@ struct ShaderProgram : public WithOpenGLBindings
{
gl()->glGetShaderInfoLog(fragment_shader, sizeof(error_buffer), NULL, error_buffer);
- LOG_ERROR << "failed to compile fragment shader!" << std::endl << error_buffer;
+ std::cerr << "failed to compile fragment shader!" << std::endl << error_buffer;
}
program = gl()->glCreateProgram();
@@ -213,7 +213,7 @@ struct ShaderProgram : public WithOpenGLBindings
if (status != GL_TRUE)
{
gl()->glGetProgramInfoLog(program, sizeof(error_buffer), NULL, error_buffer);
- LOG_ERROR << "failed to link shader program!" << std::endl << error_buffer;
+ std::cerr << "failed to link shader program!" << std::endl << error_buffer;
}
}
|
I cleaned up this for you in #385.
|
Thank you so much.I'm sorry too late to chanup the the commit. |