Skip to content

Fix class LogMessage link error in windows and compile error #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix class LogMessage link error in windows and compile error #383

wants to merge 4 commits into from

Conversation

yuanmingze
Copy link
Contributor

  • Fix class LogMessage link error in windows
  • Fix logging.cpp's compiling error
  • When exit libfreenect2::CpuDepthPacketProcessor::process is called but listener_ pointer is NULL. Adding checking to listener_
  • First time deleting not alloced memmory pointer buffer_ will fail.When create Mat buffer_ set NULL

…ECT2_API to LogMessage and getShortName to fix link error.Adding return to logging.cpp's stopTiming function to fix compile error
@floe
Copy link
Contributor

floe commented Sep 11, 2015

Looks sensible to me - @xlz @christiankerl any comments?

@floe floe added this to the 0.1 milestone Sep 11, 2015
@yuanmingze
Copy link
Contributor Author

  • The erro reported by MSVC:

viewer.obj : error LNK2019: unresolved external symbol "public: __cdecl libfreenect2::LogMessage::LogMessage(class libfreenect2::Logger *,enum libfreenect2::Logger::Level)" (??0LogMessage@libfreenect2@@qeaa@PEAVLogger@1@W4Level@21@@z) referenced in function "public: void __cdecl ShaderProgram::build(void)" (?build@ShaderProgram@@QEAAXXZ)
viewer.obj : error LNK2019: unresolved external symbol "public: __cdecl libfreenect2::LogMessage::~LogMessage(void)" (??1LogMessage@libfreenect2@@qeaa@XZ) referenced in function "public: void __cdecl ShaderProgram::build(void)" (?build@ShaderProgram@@QEAAXXZ)
viewer.obj : error LNK2019: unresolved external symbol "public: class std::basic_ostream<char,struct std::char_traits > & __cdecl libfreenect2::LogMessage::stream(void)" (?stream@LogMessage@libfreenect2@@QEAAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@xz) referenced in function "public: void __cdecl ShaderProgram::build(void)" (?build@ShaderProgram@@QEAAXXZ)
viewer.obj : error LNK2019: unresolved external symbol "class std::basic_string<char,struct std::char_traits,class std::allocator > __cdecl libfreenect2::getShortName(char const *)" (?getShortName@libfreenect2@@ya?AV?$basic_string@DU?$char_traits@D@std@@v?$allocator@D@2@@std@@PeBd@Z) referenced in function "public: void __cdecl ShaderProgram::build(void)" (?build@ShaderProgram@@QEAAXXZ)

  • I have add the message to commit message
  • Thank you for programming advice.

@xlz
Copy link
Member

xlz commented Sep 12, 2015

OK. The correct fix for this is from a later PR https://github.com/xlz/libfreenect2/commit/ca75ebafabd255a4736fb6179fb786c1e58b3272

Change viewer.h:

 #include <libfreenect2/config.h>
 #include <libfreenect2/frame_listener.hpp>
-#include <libfreenect2/logging.h>
 #include <string>
 #include <map>

 #include <../src/flextGL.h>
+#include <iostream>
 #include <GLFW/glfw3.h>

 struct Vertex
 @@ -189,7 +189,7 @@ struct ShaderProgram : public WithOpenGLBindings
         {
             gl()->glGetShaderInfoLog(vertex_shader, sizeof(error_buffer), NULL, error_buffer);

-            LOG_ERROR << "failed to compile vertex shader!" << std::endl << error_buffer;
+            std::cerr << "failed to compile vertex shader!" << std::endl << error_buffer;
         }

         gl()->glCompileShader(fragment_shader);
 @@ -199,7 +199,7 @@ struct ShaderProgram : public WithOpenGLBindings
         {
             gl()->glGetShaderInfoLog(fragment_shader, sizeof(error_buffer), NULL, error_buffer);

-            LOG_ERROR << "failed to compile fragment shader!" << std::endl << error_buffer;
+            std::cerr << "failed to compile fragment shader!" << std::endl << error_buffer;
         }

         program = gl()->glCreateProgram();
 @@ -213,7 +213,7 @@ struct ShaderProgram : public WithOpenGLBindings
         if (status != GL_TRUE)
         {
             gl()->glGetProgramInfoLog(program, sizeof(error_buffer), NULL, error_buffer);
-            LOG_ERROR << "failed to link shader program!" << std::endl << error_buffer;
+            std::cerr << "failed to link shader program!" << std::endl << error_buffer;
         }
     }

@xlz xlz mentioned this pull request Sep 12, 2015
@xlz
Copy link
Member

xlz commented Sep 12, 2015

I cleaned up this for you in #385.

  • Squashed commit "change CMakeList.txt" with previous one
  • Squashed commit "Update cpu_depth_packet_processor.cpp" with previous one.
  • Really added commit message for "fix mem free bug and null pointer error"
  • Used the correct fix for LogMessage linking error with the above diff.

@floe floe closed this in 33eb61c Sep 12, 2015
@yuanmingze
Copy link
Contributor Author

Thank you so much.I'm sorry too late to chanup the the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants