Fix FTBFS on ARM introduced in PR #103 #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #103 tried to fix a linking issue in Visual Studio 2013 on Windows 7. It added multiple explicit template instantiations which violates the standard and results in failure to build from source on ARM. Further testing failed to reproduce the linking issue with Visual Studio 2013 on Windows 8.1. Thus this commit removes the explicit template instantiations.
|
Hello, wich plateform/computer arm do you use ? |
|
Jetson TK1 |
|
I just tried to reproduce the error again, but for some reason its not causing errors (Win 7 VS 2013). Maybe due to that I started using the community edition of VS2013 - and the error only happen when using VS express.... Or perhaps an updated version of VS2013. Feel free to merge this one @christiankerl or @floe |
Closed
floe
added a commit
that referenced
this pull request
Apr 22, 2015
Fix FTBFS on ARM introduced in PR #103
|
Tested this with gcc, just to be safe, and it still works, so I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #103 tried to fix a linking issue in Visual Studio 2013 on
Windows 7. It added multiple explicit template instantiations
which violates the standard and results in failure to build
from source on ARM.
Further testing failed to reproduce the linking issue with
Visual Studio 2013 on Windows 8.1. Thus this commit removes
the explicit template instantiations.
This fixes issue #157.