Skip to content

Add Windows browser path checks to Chromium detection #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+27 −2
Open

Add Windows browser path checks to Chromium detection #1014

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c2b68cd
Add Windows browser path checks to Chromium detection
SmartManoj Nov 4, 2025
7adba85
Merge branch 'main' into chromium
SmartManoj Nov 6, 2025
87938d3
format
SmartManoj Nov 6, 2025
87718f5
Refactor Windows Chromium path checks in impl.py
SmartManoj Nov 6, 2025
2dd4ab7
Merge branch 'main' into chromium
SmartManoj Nov 16, 2025
3614642
Merge branch 'main' into chromium
simonrosenberg Nov 19, 2025
2e0060a
Merge branch 'main' into chromium
SmartManoj Nov 20, 2025
aa05bf0
Refactor Windows browser path detection logic
SmartManoj Nov 20, 2025
3830639
Remove trailing whitespace in impl.py
SmartManoj Nov 20, 2025
0fa0e43
fix: allow detection of per-user Edge installations in LOCALAPPDATA
SmartManoj Nov 20, 2025
cb7086e
Rename browsers list to windows_browsers
SmartManoj Nov 21, 2025
c6c1ef8
Merge branch 'main' into chromium
SmartManoj Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions openhands-tools/openhands/tools/browser_use/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,36 @@ def _check_chromium_available() -> str | None:
if path := shutil.which(binary):
return path

# Check common Windows installation paths
windows_chrome_paths = []
env_vars = [
("PROGRAMFILES", "C:\\Program Files"),
("PROGRAMFILES(X86)", "C:\\Program Files (x86)"),
("LOCALAPPDATA", ""),
]
windows_browsers = [
("Google", "Chrome", "Application", "chrome.exe"),
("Microsoft", "Edge", "Application", "msedge.exe"),
Copy link
Collaborator

@enyst enyst Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why do we need browsers on Windows, doesn't the browser tool work with playwright?

Copy link
Contributor Author

@SmartManoj SmartManoj Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use existing browsers instead of installing browsers using playwright (uvx playwright install chromium)

Copy link
Contributor Author

@SmartManoj SmartManoj Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

software-agent-sdk/openhands-tools/openhands/tools/browser_use/impl.py

Lines 32 to 61 in 7fed944

def _check_chromium_available() -> str | None:
"""Check if a Chromium/Chrome binary is available in PATH."""
for binary in ("chromium", "chromium-browser", "google-chrome", "chrome"):
if path := shutil.which(binary):
return path
# Check Playwright-installed Chromium
playwright_cache_candidates = [
Path.home() / ".cache" / "ms-playwright",
Path.home() / "Library" / "Caches" / "ms-playwright",
]
for playwright_cache in playwright_cache_candidates:
if playwright_cache.exists():
chromium_dirs = list(playwright_cache.glob("chromium-*"))
for chromium_dir in chromium_dirs:
# Check platform-specific paths
possible_paths = [
chromium_dir / "chrome-linux" / "chrome", # Linux
chromium_dir
/ "chrome-mac"
/ "Chromium.app"
/ "Contents"
/ "MacOS"
/ "Chromium", # macOS
chromium_dir / "chrome-win" / "chrome.exe", # Windows
]
for p in possible_paths:
if p.exists():
return str(p)
return None

Line 34, in WIndows, browser is not in Path by default,

image

Without checking for existing browser, it will work if it is installed from Playwright.

Copy link
Collaborator

@enyst enyst Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thank you.

Tiny nit: could we call them windows_browsers?

Is LOCALAPPDATA a common env var used on Windows? Is it set by default?

Copy link
Contributor Author

@SmartManoj SmartManoj Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is LOCALAPPDATA a common env var used on Windows? Is it set by default?

Yes. Source: https://devblogs.microsoft.com/oldnewthing/20231212-00/?p=109137

]

for env_var, default in env_vars:
for vendor, browser, app_dir, executable in windows_browsers:
base_path = Path(os.environ.get(env_var, default))
if base_path:
windows_chrome_paths.append(
base_path / vendor / browser / app_dir / executable
)
for chrome_path in windows_chrome_paths:
if chrome_path.exists():
return str(chrome_path)

# Check Playwright-installed Chromium
playwright_cache_candidates = [
Path.home() / ".cache" / "ms-playwright",
Path.home() / "Library" / "Caches" / "ms-playwright",
Path.home() / ".cache" / "ms-playwright", # Linux
Path.home() / "Library" / "Caches" / "ms-playwright", # macOS
Path(os.environ.get("LOCALAPPDATA", "")) / "ms-playwright", # Windows
]

for playwright_cache in playwright_cache_candidates:
if playwright_cache.exists():
chromium_dirs = list(playwright_cache.glob("chromium-*"))
Expand Down
Loading