Skip to content

Refactor sxploader #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 41 commits into from
Closed

Refactor sxploader #331

wants to merge 41 commits into from

Conversation

@zain-sohail
Copy link
Member

@zain-sohail zain-sohail commented Jan 18, 2024

No description provided.

@zain-sohail
major refactor to flash code
7192dda
@zain-sohail
update dataframe class to be able to use index and dataset keys
3d64bd0
@zain-sohail
minor changes introduced
ca17804
@zain-sohail
change majorly the class with a new initialize method. now save parqu…
3695b2c 
…et accepts parquet_paths which is useful for loading only subset of files
@zain-sohail
now uses a simpler notation and save_parquet method after loading dat…
3ac71f9 
…aframes
@zain-sohail
methods made more consistent and fixing the get_index_dataset_key
d3fcf03
@zain-sohail
include steinn's proposed solution to pulse_id channel being empty
15fe4b0
@zain-sohail
include unit tests and fixtures. still many to be done. needs to move…
96917bf 
… to appropriate directory
@zain-sohail
add more tests, simplify logic on dataframe class
4615a99
@zain-sohail
remove the gmdTunnel channel because the datafile is not correct. Rep…
e425825 
…lace with pulserSignAdc
@zain-sohail
major structure changes
a3783f3
@zain-sohail
docstrings etc
4846d24
@zain-sohail
updated buffer creation etc. tests won't work currently
5a0195e
@zain-sohail
fix linting errors and comment out tests for now
835de8e
@zain-sohail
fix the error of getting wrong attribute in loader, and fix parquet l…
7439c91 
…oading/creation
@zain-sohail
fix lint error
6531d49
@zain-sohail
cleaning up the classes
63d1cd7
@zain-sohail
add back easy access apis
c4c7b1c
@zain-sohail
small fix
808df96
@zain-sohail
small fix
4ea65d0
@zain-sohail
small fix
a511f02
@zain-sohail
fix error with pickling
0831827
@zain-sohail
use old cfg
2abbd57
@zain-sohail
docstrings fixes
b811c48
@zain-sohail
fix tests
b9ef280
@zain-sohail
fix certain problems with df_electron and add comphrehensive tests fo…
2c04f49 
…r DataFrameCreator
@zain-sohail
add tests
c4d5a2c
@zain-sohail
buffer handler tests
205257b
@zain-sohail
pre commit
5720782
@zain-sohail
ruff formated
13cb95c
@coveralls
Copy link
Collaborator

coveralls commented Jan 18, 2024

Pull Request Test Coverage Report for Build 7573470178

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 91.189%
Totals Coverage Status
Change from base Build 7572943989: 0.6%
Covered Lines: 5972
Relevant Lines: 6549
💛 - Coveralls

@zain-sohail zain-sohail mentioned this pull request Jan 18, 2024
Merged
@zain-sohail zain-sohail changed the base branch from feature-fel-loader to v1_feature_branch June 30, 2024 16:32
@zain-sohail zain-sohail deleted the refactor-sxploader branch June 30, 2024 16:33
@zain-sohail zain-sohail restored the refactor-sxploader branch June 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zain-sohail @coveralls