Skip to content

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Jan 19, 2021

Open issues:

  • Some slots may need additional props (tbc by @christophfriedrich)
  • The Map in Collection (not Collections!) view is distorted in a Jupyter env
  • StacUtils should be replaced with @radiantearth/stac-fields
  • I had it in the recent demo that expanding a Process in the Processes component took some time. During that time it said "No data available" although it seems to just be loading or so. Expanding twice again and then it showed up. Either an issue with slow connections or something different.
  • Common parts (i.e. utils.js, maybe Loading.vue/Errored.vue) should not be included multiple times
  • Check whether https://github.com/karol-f/vue-custom-element/ instead of the native vue-cli method gives better results not yet
  • Check issue that with slow connection and WC the innerHTML is empty
  • Leaflet.css gives an error in Web Editor/Hub when building. Probably needs another way of importing it in vue-components. Check whether other <style src="..."> imports work as expected.

m-mohr added 24 commits January 8, 2021 18:51
@m-mohr m-mohr added this to the 2.0.0 milestone Jan 19, 2021
@m-mohr m-mohr self-assigned this Jan 19, 2021
@m-mohr m-mohr force-pushed the dev branch 2 times, most recently from d3812c6 to 5a42df1 Compare February 18, 2021 17:43
@m-mohr m-mohr marked this pull request as ready for review February 19, 2021 09:50
@m-mohr
Copy link
Member Author

m-mohr commented Mar 4, 2021

@christophfriedrich Ready for review/merge

@christophfriedrich
Copy link
Collaborator

Thanks for letting me know, I'll look through it!

Copy link
Collaborator

@christophfriedrich christophfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out in the Hub and, with the appropriate adaptations, had no issues whatsoever
➡️ I approve for the Hub 👍

I also double-checked that everything mentioned in the Changelog is also included in the documentation (i.e. Readme), which is the case now, so other dependents shouldn't have troubles either when they convert from 1.0.x to 2.0.0.
➡️ I approve in general too 👍

@m-mohr m-mohr merged commit a9e8a31 into master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants