-
Notifications
You must be signed in to change notification settings - Fork 1
v2.0.0 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tBusMixin, add changelog, ...
…List, async components
d3812c6
to
5a42df1
Compare
@christophfriedrich Ready for review/merge |
Thanks for letting me know, I'll look through it! |
Improve docs and correct changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out in the Hub and, with the appropriate adaptations, had no issues whatsoever
➡️ I approve for the Hub 👍
I also double-checked that everything mentioned in the Changelog is also included in the documentation (i.e. Readme), which is the case now, so other dependents shouldn't have troubles either when they convert from 1.0.x to 2.0.0.
➡️ I approve in general too 👍
Open issues:
Check whether https://github.com/karol-f/vue-custom-element/ instead of the native vue-cli method gives better resultsnot yet