This repository was archived by the owner on Sep 10, 2019. It is now read-only.
Fixing a error in dismiss function #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"el" may not be defined is the user dismissed the toast manually, so before removing it we must check its existence. Easy to reproduce : close the toast before it's automatically closed, you will see a js error.
|
@Karma-design - Thank you for your submission! We really appreciate this. @WrathOfZombies - Can you please review this PR? Thanks! |
|
Sorry for the delay. I'll merge this once we have the new build process so as to keep the contribution history. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"el" may not be defined if the user dismissed the toast manually, so before removing it we must check its existence. Easy to reproduce : close the toast before it's automatically closed, you will see a js error.