Skip to content

New version parameter in wp-cli core download #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New version parameter in wp-cli core download #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8044e3
Update core.yml
Perfect-Chaos Apr 4, 2023
7958901
Update README.md
Perfect-Chaos Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ This role assumes a working virtual host (that handles `wordpress_url`).
* `wordpress_installs.{n}.dbprefix`: [default: `wp_`, optional]: Prefix for database tables
* `wordpress_installs.{n}.path`: [required]: Install directory for wordpress
* `wordpress_installs.{n}.locale`: [default: `en_US`, optional]: Language of the downloaded Wordpress
* `wordpress_installs.{n}.version`: [default: `6.2`, optional]: Version of the downloaded Wordpress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better make this optional, because this will be out-of-date too often

* `wordpress_installs.{n}.owner`: [default: `www-data`]: The name of the user that should own the install
* `wordpress_installs.{n}.group`: [default: `owner`, `www-data`]: The name of the group that should own the install
* `wordpress_installs.{n}.url`: [required]: Wordpress url
Expand Down
1 change: 1 addition & 0 deletions tasks/core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
wp-cli core download
--allow-root --no-color --path='{{ item.item.path }}'
--locale='{{ item.item.locale | default('en_US') }}'
--version='{{ item.item.version| default('6.2') }}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe only add this option if item.item.version is defined?

with_items: "{{ _check_download.results | default([]) }}"
when: item.rc != 0
tags:
Expand Down