Skip to content

Thread-safety for device descriptor sending in async plugins. #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Thread-safety for device descriptor sending in async plugins. #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/osvr/Connection/DeviceToken.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ bool OSVR_DeviceTokenObject::releaseObject(void *obj) {

void OSVR_DeviceTokenObject::setDeviceDescriptor(
std::string const &jsonString) {
auto guard = getSendGuard();
guard->lock();
Copy link
Contributor

@godbyk godbyk Apr 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to call unlock() or does a destructor take care of that? (I gave up tracing through the code after 10 minutes.)

m_getConnectionDevice()->setDeviceDescriptor(jsonString);
m_getConnection()->triggerDescriptorHandlers();
}
Expand Down