Gesture data structures #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more overriding operator& or providing implicit conversion. It's also now properly in a namespace, and uses traits classes to determine the underlying value type as well as the "invalid/empty" sentinel value.
Includes some basic tests.
Some modifications on rebase.
Contributor
|
Added the unit tests on registered string map and correlated map as well. Tests are passing |
Member
Author
There was a problem hiding this comment.
Can just use constructor, safer and easier.
Member
Author
There was a problem hiding this comment.
Also, I'd move this fixture down to just before the tests that use it.
Contributor
There was a problem hiding this comment.
Ok, using constructor now and moved fixture down before tests.
Member
Author
|
Can merge once the few changes are done. |
…tUp function, remove unused lines, use _eq not _streq for c++ str
Contributor
|
Modified the tests according to comments above, ready for merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were pulled out of the massive gesture pull request and subsequent modifications. They seem to be reasonable now, still need unit tests for the registered string map. @mars979 ?