Fix bug for $ in WiFi-passwords #294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix aims to solve incompatibility of $ inside Wifi-Passwords. I have narrowed down the errors we have experienced with one particular WiFi network to stem from this line in the code. I was considering solving this by overriding the SetWiFi global variable for our usecase, but this would not be feasible as the SetWifi variable is defined and updated inside the main OSD script based upon whether or not WiFi is connected, and is likely to cause issues elsewhere.
Wrap SSID in single quotes to handle special chars and spaces in PowerShell
|
To properly resolve any future issues related to improperly escaped SSIDs or passwords, you should use the [System.Security.SecurityElement]::Escape() method to escape invalid XML characters. This has the added benefit of ensuring that SSIDs or passwords that contain a single quote won't interfere with the quoting in the function. |
|
This has already been updated in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix aims to solve incompatibility of $ inside Wifi-Passwords. I have narrowed down the errors we have experienced with one particular WiFi network to stem from this line in the code.
I considered just overriding Start-OSDCloudGUI.json to intentionally prevent OSDCloud from applying this configuration, but I suspect that this would end up not working for other reasons.