-
Notifications
You must be signed in to change notification settings - Fork 86
Reposted : Add Support for Offline Catalog Files in OSD (Feature/support_offline_catalog) #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Reposted : Add Support for Offline Catalog Files in OSD (Feature/support_offline_catalog) #284
Conversation
ccf5350
to
8a35740
Compare
b0689cf
to
d408f92
Compare
This looks excellent, and since you're only excluding C: from the search path, it should work with network boot scenarios where no USB drive is present (ie. embedded in the boot.wim at X:\OSDCloud\Catalogs). I would love to be able to define custom paths such as the following, and then leverage the "not yet implemented" cache host variable (see #272), which looks like something we could do with this patch: |
Thank you for the feedback! Originally, since the current OSD reloads catalog files from the cache under the module path, we wanted an option to use only company-validated catalogs (Drivers and ESDs) stored in a different location, rather than relying solely on the default module path. While the OSD module regularly updates cached catalog files via GitHub Actions—allowing us to always use the latest versions—there is currently no way to specify and use a particular version of a catalog file. That’s why I proposed this pull request: to optionally allow importing catalog files from drives (excluding C:) under the \OSDCloud\Catalogs path. As you pointed out, this also enables scenarios where the catalog is embedded in the boot.wim (e.g., at X:\OSDCloud\Catalogs) or stored on USB devices. The object list will be generated from the last successfully loaded catalog file, so you can take advantage of this behavior if it fits your use case. Our ultimate goal is to host validated catalog files either on USB or online, and always use the latest version from those sources. I’m also planning to propose another pull request to: We don’t necessarily expect this pull request to be merged as-is, since we are already operating with a patched custom version internally. However, we would greatly appreciate it if equivalent functionality could be considered for inclusion in the official OSD module. |
d408f92
to
60c1fb6
Compare
60c1fb6
to
1f090f0
Compare
Hi @KatsuhiroWatanabe, do you happen to have an example user defined OS catalog you could share? EDIT: Sorry for the dumb question. I see this PR is geared towards OSDCloud v1. |
Hi @skyblaster, Thanks for your comment! Yes, I can share an example of a user-defined OS catalog. It's a very simple one — just a modified version of the original JSON (cache\archive-cloudoperatingsystems\cache\archive-cloudoperatingsystems) with updated values for the OS download URL and SHA1 hash. Since it's quite straightforward, I didn’t include it here, but I’d be happy to upload it if needed. Also, the catalog should work with both ESD and WIM files. If the image contains only a single edition, OSD defaults to using Index=1, so there's no need to specify the index manually in that case. As you mentioned, this PR is specifically for OSDCloud v1, and it's designed to work with Thanks for pointing out the new GUI in OSD.Workspace invoked via Appreciate your feedback as always! |
Update: Integrated Enhancements from feature/InintStartNet2 (PR:#288)This PR now includes additional enhancements originally proposed in feature/InintStartNet2 (PR:#288), cherry-picked for integration:
These additions complement the offline catalog support introduced in this PR, enabling more deterministic and customizable OSDCloud initialization workflows—especially in offline or controlled environments. By integrating both, we provide a more complete solution for environments requiring strict control over OSD behavior.
|
2a506db
to
f809af0
Compare
Hi @OSDeploy, Following up on this PR (originally submitted as #278, which was later replaced) and also #288, which builds on this one. I understand things can get busy, so I just wanted to check in and see if there's anything I can do to assist with the review process. I've been continuously rebasing this branch onto the latest Just to clarify — this PR does not alter existing behavior unless the new functionality is explicitly enabled through additional configuration. It should be safe to merge without impacting current users, and I hope it can be considered for inclusion. Appreciate all your work on the project! |
f809af0
to
5190ff1
Compare
Hi @OSDeploy, I've been continuously rebasing this branch onto the latest master to keep it up to date and mergeable. Please let me know if any further changes are needed. |
5190ff1
to
0f89962
Compare
Hi @OSDeploy, I've been continuously rebasing this branch onto the latest master to keep it up to date and mergeable. Please let me know if any further changes are needed. |
Prevent mistakenly downloading http contents indicating 404 error
Fix bug in the previous version. Use UTF8 for tentative workaround.
…pression Enhanced Initialize-OSDCloudStartNet.ps1 to support execution custom PowerShell scripts after establishing a network connection. Added support for suppressing automatic updates of the lastest OSD module.
0f89962
to
a0d1f92
Compare
Hi @OSDeploy, I've been continuously rebasing this branch onto the latest master to keep it up to date and mergeable. Please let me know if any further changes are needed. |
Pull Request: Add Support for Offline Catalog Files in OSD Software
This update introduces support for using offline catalog files in the OSD environment, enhancing flexibility for scenarios where the default OSD module cache may not be suitable.
Background
Since mid-April, daily OSD module updates have included OS and DriverPack catalog files (JSON and XML) under the cache folder. These updates ensure access to the latest download information.
However, some users may require customized or alternative catalog files. To support this, the update allows placing user-defined catalog files in the
USB\OSDCloud\Catalogs
folder.Key Features
Catalogs
folder.curl
-based validation step has been added. This has proven effective in internal testing.Catalogs
folder is explicitly created.Request
Please consider merging this enhancement into the
master
branch of the OSD project.EDIT (7/21/2025)
feature/InintStartNet2 (PR:#288), cherry-picked for integration: