Enabled the new sortings for application table #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…datatarget-id-to-error-message
…e/IOT-1380-update-gateway-eui-input
…/IOT-1486-add-error-message-to-email-in-use
…if no user admins found
augusthjerrild
approved these changes
Dec 1, 2023
| (query.orderOn == "id" || | ||
| query.orderOn == "name" || | ||
| query.orderOn == "updatedAt") | ||
| (query.orderOn == "id" || query.orderOn == "name" || query.orderOn == "updatedAt") |
There was a problem hiding this comment.
Can we make these === instead of == ? Even though I know it's not your code..
There was a problem hiding this comment.
Done (left != null checks as this also checks for undefined)
| } | ||
| const order: "DESC" | "ASC" = | ||
| query?.sort?.toLocaleUpperCase() == "DESC" ? "DESC" : "ASC"; | ||
| const order: "DESC" | "ASC" = query?.sort?.toLocaleUpperCase() == "DESC" ? "DESC" : "ASC"; |
There was a problem hiding this comment.
Same (it's pretty general in this file, sadly..)
| private getSortingForApplications(query: ListAllEntitiesDto): Record<string, string | number> { | ||
| const sorting: Record<string, string | number> = {}; | ||
| if ( | ||
| // TODO: Make this nicer |
There was a problem hiding this comment.
Should this be removed or is it for the future? :-)
There was a problem hiding this comment.
Future, a bit more research for a nice way of doing it if it is possible
Base automatically changed from
feature/IOT-1304-Validation-on-iot-device-type-for-backend
to
stage
December 4, 2023 10:30
…umn-options-on-application-table
fcv-iteratorIt
deleted the
feature/IOT-1403-Column-options-on-application-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.