Skip to content

#195: Sanitize recipient identifier in Maestro notification #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

#195: Sanitize recipient identifier in Maestro notification #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb247a0
#195: Sanitize recipient identifier in Maestro notification
jekuaitk Aug 29, 2025
6e83da3
#195: Updated CHANGELOG
jekuaitk Aug 29, 2025
3424f8f
Merge branch 'master' into hotfix/195-maestro-notication-recipient-sa…
rimi-itk Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ before starting to add changes. Use example [placed in the end of the page](#exa

## [Unreleased]

- [PR-202](https://github.com/OS2Forms/os2forms/pull/202)
- Removed non-digits from recipient id in Maestro digital post notifications.
- [PR-189](https://github.com/OS2Forms/os2forms/pull/189)
- Added support for MeMo 1.2 and added additional validation of MeMo actions.

Expand Down
5 changes: 4 additions & 1 deletion modules/os2forms_forloeb/src/MaestroHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,10 @@ private function sendNotificationDigitalPost(
$senderLabel = $subject;
$messageLabel = $subject;

$recipientLookupResult = $this->digitalPostHelper->lookupRecipient($recipient);
// Remove all non-digits from recipient identifier.
$recipientIdentifier = preg_replace('/[^\d]+/', '', $recipient);

$recipientLookupResult = $this->digitalPostHelper->lookupRecipient($recipientIdentifier);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion which is related directly with the changed lines:

$actions = [
(new Action())
->setActionCode(SF1601::ACTION_SELVBETJENING)
Expand Down
Loading